Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tflint execution in script after tflint --init #1381

Closed
mandresuri opened this issue Oct 21, 2024 · 0 comments
Closed

Missing tflint execution in script after tflint --init #1381

mandresuri opened this issue Oct 21, 2024 · 0 comments

Comments

@mandresuri
Copy link
Contributor

Description:
In the current version of the script, after initializing tflint using --init, the actual linting step with tflint --config="${cfg}" is missing. This causes Terraform files to not be linted.

Expected Behavior:
tflint should lint the Terraform files after --init is executed

Actual Behavior:
The script initializes tflint, but it doesn't perform the actual linting of the Terraform files.

Steps to Reproduce:
Run the script.
Observe that the linting step is not executed after initialization.
Proposed Solution:
Add the missing step:
&& tflint --config="${cfg}" in https://github.com/fluidattacks/makes/blob/main/src/args/lint-terraform/entrypoint.sh

rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 21, 2024
- Add tflint to the lint-terraform built-in

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 21, 2024
- Add tflint to the lint-terraform built-in

Signed-off-by: Robin Quintero <[email protected]>
@rohaquinlop rohaquinlop reopened this Oct 22, 2024
dsalaza4 added a commit that referenced this issue Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants