Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider deprecating MAKES_NON_ROOT #1357

Closed
dsalaza4 opened this issue Jul 25, 2024 · 1 comment
Closed

Consider deprecating MAKES_NON_ROOT #1357

dsalaza4 opened this issue Jul 25, 2024 · 1 comment

Comments

@dsalaza4
Copy link
Contributor

MAKES_NON_ROOT is only supported on a container level:

makes/makes/container-image/main.nix

Line 135 in 4e2e7ab

(__nixpkgs__.writeShellScriptBin "m" ''

This creates two m commands: One with MAKES_NON_ROOT support and another one without it.

If you try to reinstall makes via nix-env from the container, you end up with a Makes version that does not support MAKES_NON_ROOT. This creates strange behaviors that are very difficult to debug.
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Aug 13, 2024
@dsalaza4
refac(back): fluidattacks#1357 deprecate makes non root
7ef3cc9 
- Deprecate functionality in order to keep
makes simple and bring back a single binary

Signed-off-by: Daniel Salazar <[email protected]>
@dsalaza4
Copy link
Contributor Author

We will keep the makes user available so users can use it for tools that require to be executed with a non-root user.

dsalaza4 added a commit that referenced this issue Aug 13, 2024
@dsalaza4
Merge pull request #1368 from dsalaza4/main
8aef622 
refac(back): #1357 deprecate makes non root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsalaza4