Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to nixfmt #1332

Closed
rohaquinlop opened this issue May 31, 2024 · 1 comment
Closed

Migrate to nixfmt #1332

rohaquinlop opened this issue May 31, 2024 · 1 comment
Assignees
@rohaquinlop

Comments

@rohaquinlop
Copy link
Contributor

nixfmt will form the basis for the initial official standard Nix formatter, as established by RFC 166. We should migrate from Alejandra to nixfmt
@rohaquinlop rohaquinlop self-assigned this May 31, 2024
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 4, 2024
@rohaquinlop
feat(back): fluidattacks#1332 use nixfmt
509f487 
- Migrate from Alejandra to nixfmt
- Formatted all the nix files using nixfmt

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 4, 2024
@rohaquinlop
feat(back): fluidattacks#1332 use nixfmt
d90c9bd 
- Migrate from Alejandra to nixfmt
- Formatted all the nix files using nixfmt

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit that referenced this issue Jun 4, 2024
@rohaquinlop
Merge pull request #1333 from rohaquinlop/issue-1332
7e4ac2b 
feat(back): #1332 use nixfmt
@rohaquinlop rohaquinlop reopened this Jun 17, 2024
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 17, 2024
@rohaquinlop
feat(docs): fluidattacks#1332 update docs
f43d1c5 
- Change from Alejandra to nixfmt in the formatNix
section of the docs.

Signed-off-by: Robin Quintero <[email protected]>
@blotero
Copy link

blotero commented Jun 17, 2024 •
edited
Loading

nixfmt can only fail when the check flag is used, CI systems which rely on a job with the /formatNix builtin would not fail under non compliant nix code. Is this intentional?

https://github.com/NixOS/nixfmt/blob/master/main/Main.hs#L59

@rohaquinlop rohaquinlop reopened this Jun 24, 2024
rohaquinlop pushed a commit to rohaquinlop/makes that referenced this issue Jun 24, 2024
feat(back): fluidattacks#1332 add check flag to nixfmt
2a728f4 
- Run check only in CI, locally it will format the code

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop pushed a commit to rohaquinlop/makes that referenced this issue Jun 24, 2024
feat(back): fluidattacks#1332 add check flag to nixfmt
e1c3331 
- Run check only in CI, locally it will format the code
- Update docs to show the use of nixfmt
instead of Alejandra

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 24, 2024
@rohaquinlop
feat(back): fluidattacks#1332 add check flag to nixfmt
d5806b3 
- Run check only in CI, locally it will format the code
- Update docs to show the use of nixfmt
instead of Alejandra

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 24, 2024
@rohaquinlop
feat(back): fluidattacks#1332 add check flag to nixfmt
8bd145f 
- Run check only in CI, locally it will format the code
- Update docs to show the use of nixfmt
instead of Alejandra

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 24, 2024
@rohaquinlop
feat(back): fluidattacks#1332 add check flag to nixfmt
f026919 
- Run check only in CI, locally it will format the code
- Update docs to show the use of nixfmt
instead of Alejandra

Signed-off-by: Robin Quintero <[email protected]>
dsalaza4 added a commit that referenced this issue Jun 24, 2024
@dsalaza4
Merge pull request #1340 from rohaquinlop/issue-1332
dd54c58 
feat(back): #1332 add check flag to nixfmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohaquinlop rohaquinlop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blotero @rohaquinlop