Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MakeNodeJsLock is creating lockfiles v3 #1290

Closed
jpverde opened this issue Feb 14, 2024 · 0 comments
Closed

MakeNodeJsLock is creating lockfiles v3 #1290

jpverde opened this issue Feb 14, 2024 · 0 comments
Assignees
@jpverde
Labels
difficulty::low good first issue Nice for a first contribution

Comments

@jpverde
Copy link
Contributor

jpverde commented Feb 14, 2024

Lockfiles v3 are not fully supported yet, lets make the lockfile version default to 2 and receive it as an optional argument.
@jpverde jpverde added good first issue Nice for a first contribution difficulty::low labels Feb 14, 2024
@jpverde jpverde self-assigned this Feb 14, 2024
jpverde added a commit to jpverde/makes that referenced this issue Feb 14, 2024
@jpverde
refac(cross): fluidattacks#1290 update makenodejslock
bcd6818 
- Update makeNodeJsLock utility to support the lock_file version

Signed-off-by: John Perez <[email protected]>
jpverde added a commit to jpverde/makes that referenced this issue Feb 14, 2024
@jpverde
refac(cross): fluidattacks#1290 update makenodejslock
1b8c6ef 
- Update makeNodeJsLock utility to support the lock_file version

Signed-off-by: John Perez <[email protected]>
jpverde added a commit that referenced this issue Feb 14, 2024
@jpverde
Merge pull request #1291 from jpverde/main
64fd086 
refac(cross): #1290 update makenodejslock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpverde jpverde

Labels
difficulty::low good first issue Nice for a first contribution
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsalaza4 @jpverde