Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inputs.nixpkgs #1097

Closed
dsalaza4 opened this issue May 24, 2023 · 0 comments
Closed

Update inputs.nixpkgs #1097

dsalaza4 opened this issue May 24, 2023 · 0 comments
Assignees

Comments

@dsalaza4
Copy link
Contributor

dsalaza4 commented May 24, 2023

Makes currently uses a pretty old version of nixpkgs to build its container:

makes/makes.nix

Lines 138 to 141 in 1311f28

nixpkgs = fetchNixpkgs {
rev = "f88fc7a04249cf230377dd11e04bf125d45e9abe";
sha256 = "1dkwcsgwyi76s1dqbrxll83a232h9ljwn4cps88w9fam68rf8qv3";
};

Let's:

  1. Update inputs.nixpkgs to a more recent version
  2. Make sure the container is building properly
  3. Prefer using __nixpkgs__ for building the container
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Sep 5, 2023
- Replace inputs.nixpkgs with __nixpkgs__ at container-image

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Sep 6, 2023
- Replace inputs.nixpkgs with __nixpkgs__ at container-image

Signed-off-by: Robin Quintero <[email protected]>
dsalaza4 added a commit that referenced this issue Sep 6, 2023
feat(build): #1097 deprecate inputs.nixpkgs
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Sep 6, 2023
- replace `inputs.nixpkgs` with `__nixpkgs__` at `/makes.nix`

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Sep 6, 2023
- Deprecate inputs.nixpkgs from `/makes/docs/runtime/main.nix`

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Sep 6, 2023
- Deprecate inputs.nixpkgs from `/makes/nested/main.nix`

Signed-off-by: Robin Quintero <[email protected]>
dsalaza4 added a commit that referenced this issue Sep 6, 2023
feat(build): #1097 deprecate inputs.nixpkgs
dsalaza4 added a commit that referenced this issue Sep 6, 2023
feat(build): #1097 deprecate inputs.nixpkgs
dsalaza4 added a commit that referenced this issue Sep 6, 2023
feat(build): #1097 deprecate inputs.nixpkgs
@dsalaza4 dsalaza4 closed this as completed Sep 8, 2023
danmur97 pushed a commit to danmur97/makes that referenced this issue Sep 19, 2023
- Deprecate inputs.nixpkgs from `/makes/nested/main.nix`

Signed-off-by: Robin Quintero <[email protected]>
danmur97 pushed a commit to danmur97/makes that referenced this issue Sep 19, 2023
- Deprecate inputs.nixpkgs from `/makes/docs/runtime/main.nix`

Signed-off-by: Robin Quintero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants