Fix in_tail input messages loss when receive_lines fail. fix #699 #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 19, 2016
|
@sonots @tagomoris @zheolong How about this? |
|
@repeatedly I think it's great. |
| end | ||
| end | ||
|
|
||
| return true |
There was a problem hiding this comment.
true/false is ambiguous what it means. please write a yardoc comment for the return value.
|
commented |
|
If there is no problem, I will merge this patch today and release new fluentd. |
repeatedly
added a commit
that referenced
this pull request
Mar 2, 2016
Fix in_tail input messages loss when receive_lines fail. fix #699
repeatedly
added a commit
that referenced
this pull request
Mar 2, 2016
Fix in_tail input messages loss when receive_lines fail. fix #699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #700. Update patch and rebase to master.