Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip_network_error_at_init option to forward output. fix #731 #735

Closed
wants to merge 1 commit into from

Conversation

repeatedly
Copy link
Member

This option is available when heartbeat_type is tcp for now.

This option is available when heartbeat_type is tcp for now.
@repeatedly
Copy link
Member Author

Do we need to support udp heartbeat?

@harmw
Copy link

harmw commented Jan 4, 2016

I would say this feature should be protocol-agnostic, thus yes UDP should be supported, though you could just merge it now with a disclaimer of some sorts and only support TCP 😄

To my understanding, the heartbeat is used to ping/check a backend or forwarder, whereas this PR is about mere DNS resolving.

@mgcrea
Copy link

mgcrea commented Feb 26, 2016

👍 this is really needed!

@tagomoris
Copy link
Member

I think UDP should be supported too.
Any progress?

@repeatedly
Copy link
Member Author

We can support UDP but it makes code complicated, e.g. lazy initialization for socket and Heartbeater.
It needs re-writing socket handling of out_forward.
So I want to delay UDP support after other important changes are merged.

@tagomoris
Copy link
Member

I will come back to this issue after implementing forward plugins with socket/server plugin helpers and v0.14 APIs.

@tagomoris
Copy link
Member

I created #1399 based on v0.14 code base.

@repeatedly repeatedly closed this Jan 5, 2017
@ganmacs ganmacs deleted the skip-network-error-during-plugin-setup branch July 11, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending To be done in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants