Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process_name parameter in system to change fluentd's process name #708

Merged
merged 1 commit into from
Nov 25, 2015

Conversation

repeatedly
Copy link
Member

Like https://github.com/cubicdaiya/fluent-plugin-setproctitle plugin.
Set process_name,

<system>
  process_name foo
</system>

ps result is below.

% ps aux | grep foo
repeatedly      45673   0.4  0.2  2523252  38620 s001  S+    7:04AM   0:00.44 worker:foo
repeatedly      45647   0.0  0.1  2481260  23700 s001  S+    7:04AM   0:00.40 supervisor:foo

@tagomoris
Copy link
Member

👍

@sonots
Copy link
Member

sonots commented Nov 21, 2015

I can imagine that someone requests that he wants to set entire proctitle. How about providing supervisor_process_name, and worker_process_name options?

Also, should note how it behaves on Windows (maybe, on docs). How does it behave?

@cubicdaiya
Copy link

👍

@repeatedly
Copy link
Member Author

@sonots

I can imagine that someone requests that he wants to set entire proctitle.

Hmm... any situation? I sometimes received this feature request for better fluentd process management because current process name is bit messy.
Current patch identifies supervisor and worker using a prefix. Could you show me the good example?

@sonots
Copy link
Member

sonots commented Nov 24, 2015

It just depends on users' preference. He may want to name as fluentd worker rather than worker:fluentd.

@repeatedly
Copy link
Member Author

If it is may, I think we don't need to support two parameters for now.

@repeatedly
Copy link
Member Author

My first implementation was fluentd-supervisor and fluentd-worker.
I'm not sure which is better.

@repeatedly
Copy link
Member Author

No against for worker and supervisor prefix, I will merge it.

repeatedly added a commit that referenced this pull request Nov 25, 2015
Add process_name parameter in system to change fluentd's process name
@repeatedly repeatedly merged commit 85d07c3 into master Nov 25, 2015
@repeatedly repeatedly deleted the support-process-name-configuration branch December 3, 2015 10:32
repeatedly added a commit that referenced this pull request Dec 8, 2015
Add process_name parameter in system to change fluentd's process name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants