out_forward raises ZeroDivisionError when no <server> is available #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no <server> is set to out_forward plugin, `Fluent::ForwardOutput#rebuild_weight_array` raises ZeroDivisionError at `coe = (regular_nodes.size * 6) / weight_array.size`. This change gives more useful error message to uses instead of unfriendly ZeroDivisionError message.
|
Could you add a test for this change? |
|
Added test |
|
@sonots good 👍 |
repeatedly
added a commit
that referenced
this pull request
Nov 24, 2015
out_forward raises ZeroDivisionError when no <server> is available
repeatedly
added a commit
that referenced
this pull request
Dec 8, 2015
out_forward raises ZeroDivisionError when no <server> is available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no is set to out_forward plugin,
Fluent::ForwardOutput#rebuild_weight_arrayraises ZeroDivisionErrorat
coe = (regular_nodes.size * 6) / weight_array.size. This changegives more useful error message to uses instead of unfriendly
ZeroDivisionError message.