Add new_xxx api to parser and formatter #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeatedly
added
the
feature request
repeatedly
added a commit
that referenced
this pull request
Dec 3, 2014
…matter Add new_xxx api to parser and formatter
repeatedly
added a commit
that referenced
this pull request
Dec 8, 2014
…matter Add new_xxx api to parser and formatter
|
cherry-picked to v0.10 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second try of #495.
Note that
new_parserreturns actual XXXParser, not TextParser.Keep existing instantiation approach for existing plugins.
After merged this PR, I will implement
Fluent::ParserandFluent::Formatterfor plugins.Fluent::Parserprovideparseandcallmethods.callis for backward compatibility.