Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport(v1.16) test_out_file: fix file open mode for binary file #4798

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jan 29, 2025

Which issue(s) this PR fixes:

Backport #4728

What this PR does / why we need it:

Fix the file open mode so that gz files can be read properly.

Docs Changes:

Release Note:

Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
Copy link
Contributor Author

kenhys commented Jan 29, 2025

git switch -c backport-pr4728 --track origin/v1.16
git cherry-pick b11aab6376c3f3ba6d9f391328aa49981187a45e

@daipom daipom added this to the v1.16.7 milestone Jan 29, 2025
@daipom daipom merged commit ce38a8d into v1.16 Jan 29, 2025
12 of 16 checks passed
@daipom daipom deleted the backport-pr4728 branch January 29, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants