Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport(v1.16) test_out_forward: remove unnecessary ack_response_timeout setting (#4685) #4791

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jan 29, 2025

Which issue(s) this PR fixes:

Backport #4685

What this PR does / why we need it:

Seems that timeout setting is short in ack_response_timeout.
Seems that It may take some time to receive a ACK response
so the process in ack handler has expired and the node is disabled.

This PR will remove unnecessary ack_response_timeout settings for the test

Docs Changes:

Release Note:

)

Seems that timeout setting is short in ack_response_timeout.
Seems that It may take some time to receive a ACK response
so the process in ack handler has expired and the node is disabled.

Signed-off-by: Watson <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
@kenhys
Copy link
Contributor Author

kenhys commented Jan 29, 2025

git switch -c backport-pr4685 --track origin/v1.16
git cherry-pick 17005d5256f707cad8b75144bc0d961b1aece25f

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daipom daipom merged commit 0b2126a into v1.16 Jan 29, 2025
12 of 16 checks passed
@daipom daipom deleted the backport-pr4685 branch January 29, 2025 02:21
@daipom daipom added this to the v1.16.7 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants