Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport(v1.16) test_in_udp: Reduce execution time of message_length_limit test (#4682) #4790

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jan 29, 2025

Which issue(s) this PR fixes:

Backport #4682

What this PR does / why we need it:

Although it's improved in #4676, it still takes 5 seconds on windows. It can be reduced more by sending data that doesn't exceed the limit.

  test: message_length_limit:                           .: (1.104855)

Docs Changes:

Release Note:

Although it's improved in #4676, it still takes 5 seconds on windows.
It can be reduced more by sending data that doesn't exceed the limit.

```
  test: message_length_limit:                           .: (1.104855)
```

Signed-off-by: Takuro Ashie <[email protected]>
@kenhys
Copy link
Contributor Author

kenhys commented Jan 29, 2025

git switch -c backport-pr4682 --track origin/v1.16
git cherry-pick fa01800d0ba97826928293fd5ca2116be610cfc6

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daipom daipom merged commit 60c969a into v1.16 Jan 29, 2025
10 of 16 checks passed
@daipom daipom deleted the backport-pr4682 branch January 29, 2025 02:14
@daipom daipom added this to the v1.16.7 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants