make FilePositionEntry thread-safe #1966
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1804 and #1963
fluent-plugin-protometheus calls
FilePositionEntry#read_pos
andFilePositionEntry#read_inode
by usinginstance_variable_get
to get current position and inode as metrics. I understand it is unsupported use.FilePositionEntry's methods are not thread-safe because each methods share
@file
to read data from file. So race happens between in_tail plugin and fluent-plugin-protometheus plugin.But now I found instance variable
@pe
ofFluent::Plugin::TailInput::TailWatcher
is accessible by outside. So I think it is better to be thread-safe to use FilePositionEntry without considering my usecase.How do you think?