Add more available characters for tag part of syslog format #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 👍 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the TAG part of syslog format (RFC3164).
RFC3164 says "Any non-alphanumeric character will terminate the TAG field". But some syslog senders send non-alphanumeric characters as a part of TAG, so currently fluentd allowed some non-alphanumeric characters:
[a-zA-Z0-9_\/\.\-]. In the real world, there are cases that require more characters. For example, Cisco ASA Series Syslog Messages includes%like%ASA-1-101001. It is useful if fluentd can handle such messages.rsyslog syslog-ng and accept all characters except
:and[:https://github.com/rsyslog/rsyslog/blob/master/tools/pmrfc3164.c#L314-L347
https://github.com/balabit/syslog-ng/blob/master/modules/syslogformat/syslog-format.c#L558-L609
This PR follows them.
Once this PR is merged, I will send a PR for the master branch.