Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More rubyish way for Fluent::Plugin::Output#formatted_to_msgpack_binary #1538

Closed
kenhys opened this issue Apr 12, 2017 · 2 comments
Closed

Comments

@kenhys
Copy link
Contributor

kenhys commented Apr 12, 2017

This is suggestion about method name about Fluent::Plugin::Output#formated_to_msgpack_binary

  • fluentd version:

    • fluentd 0.14.x or later.
  • environment infomation:

    • OS independent
  • Your problem explanation. If you have an error logs, write it together.

    • Expected method name
      Fluent::Plugin::Output#formatted_to_msgpack_binary?

    • Actual method name
      Fluent::Plugin::Output#formatted_to_msgpack_binary

Traditionally, the method which returns boolean result is named with ? suffix. That is more rubyish way to do it and easy to understand the behavior of #formated_to_msgpack_binary. How about alias?

@repeatedly
Copy link
Member

LGTM.
@tagomoris @mururu How about this?

@mururu
Copy link
Member

mururu commented Apr 12, 2017

LGTM

repeatedly added a commit that referenced this issue Apr 19, 2017
…-rubyish

Add formatted_to_msgpack_binary? to Output plugin API. fix #1538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants