You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is suggestion about method name about Fluent::Plugin::Output#formated_to_msgpack_binary
fluentd version:
fluentd 0.14.x or later.
environment infomation:
OS independent
Your problem explanation. If you have an error logs, write it together.
Expected method name
Fluent::Plugin::Output#formatted_to_msgpack_binary?
Actual method name
Fluent::Plugin::Output#formatted_to_msgpack_binary
Traditionally, the method which returns boolean result is named with ? suffix. That is more rubyish way to do it and easy to understand the behavior of #formated_to_msgpack_binary. How about alias?
The text was updated successfully, but these errors were encountered:
This is suggestion about method name about Fluent::Plugin::Output#formated_to_msgpack_binary
fluentd version:
environment infomation:
Your problem explanation. If you have an error logs, write it together.
Expected method name
Fluent::Plugin::Output#formatted_to_msgpack_binary?
Actual method name
Fluent::Plugin::Output#formatted_to_msgpack_binary
Traditionally, the method which returns boolean result is named with
?
suffix. That is more rubyish way to do it and easy to understand the behavior of #formated_to_msgpack_binary. How aboutalias
?The text was updated successfully, but these errors were encountered: