Skip to content

Commit

Permalink
config: bin: Ensure thread safety on reloading by default
Browse files Browse the repository at this point in the history
Signed-off-by: Hiroshi Hatake <[email protected]>
  • Loading branch information
cosmo0920 authored and edsiper committed Jun 13, 2023
1 parent 5b534a1 commit cbdb8df
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 3 additions & 0 deletions src/flb_config.c
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,9 @@ struct flb_config *flb_config_init()
config->sched_cap = FLB_SCHED_CAP;
config->sched_base = FLB_SCHED_BASE;

/* reload */
config->ensure_thread_safety_on_hot_reloading = FLB_TRUE;

#ifdef FLB_HAVE_SQLDB
mk_list_init(&config->sqldb_list);
#endif
Expand Down
6 changes: 3 additions & 3 deletions src/fluent-bit.c
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ static void flb_help(int rc, struct flb_config *config)
print_opt("-q, --quiet", "quiet mode");
print_opt("-S, --sosreport", "support report for Enterprise customers");
print_opt("-Y, --enable-hot-reload", "enable for hot reloading");
print_opt("-W, --ensure-thread-safety-on-hot-reloading", "ensure thread safety on hot reloading");
print_opt("-W, --disable-thread-safety-on-hot-reloading", "disable thread safety on hot reloading");
print_opt("-V, --version", "show version number");
print_opt("-h, --help", "print this help");

Expand Down Expand Up @@ -805,7 +805,7 @@ int flb_main(int argc, char **argv)
#ifdef FLB_HAVE_CHUNK_TRACE
{ "enable-chunk-trace", no_argument, NULL, 'Z' },
#endif
{ "ensure-thread-safety-on-hot-reload", no_argument, NULL, 'W' },
{ "disable-thread-safety-on-hot-reload", no_argument, NULL, 'W' },
{ NULL, 0, NULL, 0 }
};

Expand Down Expand Up @@ -992,7 +992,7 @@ int flb_main(int argc, char **argv)
break;
case 'W':
flb_cf_section_property_add(cf_opts, service->properties,
FLB_CONF_STR_HOT_RELOAD_ENSURE_THREAD_SAFETY, 0, "on", 0);
FLB_CONF_STR_HOT_RELOAD_ENSURE_THREAD_SAFETY, 0, "off", 0);
break;
#ifdef FLB_HAVE_CHUNK_TRACE
case 'Z':
Expand Down

0 comments on commit cbdb8df

Please sign in to comment.