Deprecate "table created" error #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid reaching the retry limit cf. fluent/fluentd#2123
to avoid reaching the retry limit cf. fluent/fluentd#2123
joker1007
reviewed
Sep 10, 2018
lib/fluent/plugin/bigquery/writer.rb
Outdated
| type: @options[:time_partitioning_type].to_s.upcase, | ||
| field: @options[:time_partitioning_field] ? @options[:time_partitioning_field].to_s : nil, | ||
| expiration_ms: @options[:time_partitioning_expiration] ? @options[:time_partitioning_expiration] * 1000 : nil | ||
| }.compact |
There was a problem hiding this comment.
Hash#compact is added when ruby version is 2.4.0.
But current version of this plugin supports ruby-2.3.0 or later.
Please use reject { |_, v| v.nil? }.
abicky
force-pushed
the
deprecate-table-created-error
branch
from
dd6d00e to
06074eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior not to raise so many errors when
auto_create_tableis set totrue.Fluentd sometimes drops all chunks without transition to secondary if so many errors occur.
See fluent/fluentd#2123 for more details.