Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openal: Fix build with emsdk >= 3.1.65 #44

Merged

Conversation

rgonzalezfluendo
Copy link

The emscripten project did a commit replacing copied OpenAL extensions header alext.h with its own reduced version. [1]

It was done due to incompatibilities BSD licence and MIT licence.

[1] emscripten-core/emscripten@cf8a0d000

The emscripten project did a commit replacing copied OpenAL
extensions header alext.h with its own reduced version. [1]

It was done due to incompatibilities BSD licence and MIT licence.

[1] emscripten-core/emscripten@cf8a0d000
Copy link

@cfoch cfoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming all these macros really exist.

@rgonzalezfluendo rgonzalezfluendo merged commit 79343ed into wasm-main-openal Dec 18, 2024
@rgonzalezfluendo
Copy link
Author

Integrated with guw:

$ poetry run guw -l debug guw/gstreamer.gst.wasm.toml update --keep --backup origin/wasm-main-openal_fix_emsdk_3_1_68 wasm-main-openal
[2024-12-18 09:24:54,792] INFO main.py:111 Work directory at /tmp/tmplwrxtsb9
[2024-12-18 09:25:45,182] DEBUG main.py:126 Adding remote freedesktop at [email protected]:gstreamer/gstreamer.git
[2024-12-18 09:25:45,185] DEBUG main.py:128 Fetching remote freedesktop
[2024-12-18 09:26:02,251] INFO main.py:134 Syncing feature wasm-main-openal with previous active wasm-main-test
[2024-12-18 09:26:02,251] DEBUG main.py:137 Creating local branch origin/wasm-main-openal
[2024-12-18 09:26:02,353] DEBUG main.py:159 Updating feature wasm-main-openal with origin/wasm-main-openal_fix_emsdk_3_1_68
[2024-12-18 09:26:02,386] DEBUG main.py:88 Rebasing wasm-main-openal onto wasm-main-test until origin/wasm-main-test
[2024-12-18 09:26:02,422] INFO main.py:134 Syncing feature wasm-main-gl-support with previous active wasm-main-openal
[2024-12-18 09:26:02,423] DEBUG main.py:137 Creating local branch origin/wasm-main-gl-support
[2024-12-18 09:26:02,442] DEBUG main.py:88 Rebasing wasm-main-gl-support onto wasm-main-openal until origin/wasm-main-openal
[2024-12-18 09:26:02,497] INFO main.py:134 Syncing feature wasm-main-videodec with previous active wasm-main-gl-support
[2024-12-18 09:26:02,497] DEBUG main.py:137 Creating local branch origin/wasm-main-videodec
[2024-12-18 09:26:02,522] DEBUG main.py:88 Rebasing wasm-main-videodec onto wasm-main-gl-support until origin/wasm-main-gl-support
[2024-12-18 09:26:02,582] INFO main.py:134 Syncing feature wasm-main-webtransport with previous active wasm-main-videodec
[2024-12-18 09:26:02,582] DEBUG main.py:137 Creating local branch origin/wasm-main-webtransport
[2024-12-18 09:26:02,603] DEBUG main.py:88 Rebasing wasm-main-webtransport onto wasm-main-videodec until origin/wasm-main-videodec
[2024-12-18 09:26:02,672] INFO main.py:134 Syncing feature wasm-main-wip with previous active wasm-main-webtransport
[2024-12-18 09:26:02,672] DEBUG main.py:137 Creating local branch origin/wasm-main-wip
[2024-12-18 09:26:02,695] DEBUG main.py:88 Rebasing wasm-main-wip onto wasm-main-webtransport until origin/wasm-main-webtransport
[2024-12-18 09:26:02,797] INFO main.py:192 Making target branch gst.wasm based on origin/wasm-main-wip
[2024-12-18 09:26:02,818] DEBUG main.py:196 Backing up target branch into gst.wasm-2024-12-18_09-26-02
[2024-12-18 09:26:02,858] DEBUG main.py:106 Pushing wasm-main-openal to origin
[2024-12-18 09:26:05,373] DEBUG main.py:106 Pushing wasm-main-gl-support to origin
[2024-12-18 09:26:07,820] DEBUG main.py:106 Pushing wasm-main-videodec to origin
[2024-12-18 09:26:10,006] DEBUG main.py:106 Pushing wasm-main-webtransport to origin
[2024-12-18 09:26:12,031] DEBUG main.py:106 Pushing wasm-main-wip to origin
[2024-12-18 09:26:14,470] DEBUG main.py:106 Pushing gst.wasm-2024-12-18_09-26-02 to origin
[2024-12-18 09:26:16,708] DEBUG main.py:106 Pushing gst.wasm to origin

@rgonzalezfluendo rgonzalezfluendo deleted the wasm-main-openal_fix_emsdk_3_1_68 branch December 18, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants