feat(air)!: change fold over canon map iterator contents [fixes VM-620] #843
Conversation
raftedproc
added
C-bug
raftedproc
changed the title
| true | ||
| } | ||
| } else { | ||
| false |
There was a problem hiding this comment.
I think complying with filter interface is too much hassle here.
Try to rewrite it with a simple for loop (pushing to a Vec) to see if it shorter and clearer.
There was a problem hiding this comment.
Replaced. The suggested approach delivers a smaller nibble for sure.
|
It worth adding a small tests that just demonstrates specific bit of functionality, e.g. |
JFYI I altered the existing test to test duplicates iterating with fold over SCM. |
|
|
||
| for val in canon_stream_map.canon_stream_map.iter().rev() { | ||
| if let Some(map_key) = StreamMapKey::from_kvpair_owned(val) { | ||
| if met_keys.get(&map_key).is_none() { |
There was a problem hiding this comment.
It's just !met_keys.contains(&map_key).
|
|
||
| for val in canon_stream_map.canon_stream_map.iter().rev() { | ||
| if let Some(map_key) = StreamMapKey::from_kvpair_owned(val) { | ||
| if !met_keys.contains(&map_key) { |
There was a problem hiding this comment.
It would be slightly more performant with the Entry API (no double hashing and lookup), but I'm not sure it worth it.
raftedproc
changed the title
This is to align the spec with the implementation. The spec tells
folditerates over unique(conflicts are resolved with LastWriteWin policy) kv pairs. The implementation violates this delivering all kv pairs together with duplicates.