Feature: Remove empty users

flowwer-dev · Dec 12, 2024 · 3b54903 · 3b54903
1 parent 5eb3d4f
commit 3b54903
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 0 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -43213,6 +43213,7 @@ module.exports = (pulls) => groupReviews(pulls)
 /***/ ((module) => {
 
 module.exports = (exclude, username) => {
+  if (!username) return false;
   if (exclude.test) return !exclude.test(username);
   if (exclude.includes) return !exclude.includes(username);
   return true;

diff --git a/src/interactors/getUsers/__tests__/filterUser.test.js b/src/interactors/getUsers/__tests__/filterUser.test.js
@@ -27,4 +27,13 @@ describe('Interactors | getUsers | .filterUser', () => {
       'jartmez',
     ]);
   });
+
+  it('removes the empty users', () => {
+    const exclude = /bot/;
+    const results = ['user1', '', null, undefined].filter((reviewer) => filterUser(exclude, reviewer));
+    expect(results.length).toEqual(1);
+    expect(results).toEqual([
+      'user1',
+    ]);
+  });
 });
diff --git a/src/interactors/getUsers/filterUser.js b/src/interactors/getUsers/filterUser.js
@@ -1,4 +1,5 @@
 module.exports = (exclude, username) => {
+  if (!username) return false;
   if (exclude.test) return !exclude.test(username);
   if (exclude.includes) return !exclude.includes(username);
   return true;