-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Implement custom primary color #106
Conversation
Hello @Biowulf21, thank you for taking your time to implement this feature. It would be more appreciated if we discuss before jumping to implementations. As this is a very young project, I have so many things in mind, and trying my best to list them down in the issues. Moving forward with your PR, we have few problems.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will have this in Flow if you make following changes:
- Remove
colornames
package, and not use color names for now or use a localized color name provider - (MAYBE) not require restart after changing theme color. You can write sth in
Flow
(the main app widget) and have it transcend the changes. Nice to have this, but not necessary. - Provide a video demonstrating the implemented feature
Again, thank you for the PR! Let me know if you want to proceed with the suggestions and review |
Hello, @sadespresso. I'll implement these changes as soon as I get home. I'm out of the house at the moment. As for communicating features moving forward, I'd like to connect with you on discord if that's alright with you. Thanks. |
:D :D We have a discord server, and you can find me, or my account in there! |
Hello @sadespresso, can you please point me into the right direction as to which color picker we'll be using? I can refactor my current implementation if you already have a package in mind. As for the other changes you requested, I've already gone through them. Please let me know if you have any questions/suggestions on the implementation. Lastly, here is the video demo that you requested for the feature: Thanks. |
Hello @Biowulf21 Thank you so much for the work! I really appreciate it. I will check it out once I have time, should be soon. |
LGTM. Thank you! In the future, I plan to give option to use Also, in the future, we'd have much more simpler color selector. |
Hi @sadespresso, this is the feature implementation for #105 .
This is my first time submitting a PR for a FOSS repo, so I do apologize in advance if my code is not up to FOSS standard. I'd like to work on this project on my spare time, as I see a lot of potential in this application 😄 .