Rebase #2
Merged
Rebase #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the number of heap allocations (and with this heap fragmentation) by allocaing static lenght buffers on the stack or global memory regions instead of the heap.
Fixes finding biologist79#202 and adds missing guards against NULL returns from malloc and friends Also adds missing calls to "free" before return statements.
xQueueSend creates a copy of the data in it's internal memory. So there is no need to duplicate the data beforehand.
Add missing free to return statements and also free the allocated char* array after releasing all strings form it.
Return nullptr on error and a pointer to the first element of the arra on success.
Here we need brackets to force the correct memory size calculation (point before line calculations)
Bugfix/heap handling
Add text to AP setup in case javascript does not work (f.e. older WebView implementations / captive portals)
By hijacking DNS request made by Android and responding with our AP setup page, we can force the phone into captive portal mode. This will automatically redirect the user to the setup page as soon as he connects to the access point.
i18n and captive portal bugfix
Fix for playing files via Web-UI for Arduino >=2.0.5
Bugfix: playlistcache was invalid after "Rename"
Bugfix: Corrupted files after HTTP-upload
LPCD, RFID_IRQ on port-expander: fix compiler warning portTICK_RATE_MS is deprecated, use portTICK_PERIOD_MS instead (espressif/esp-idf#51) Cppcheck: Fix some warnings/hints
This reverts commit 788a8e1.
This is to match the clang-format settings specified in .clang-format.
Rename build workflow and make it faster. Both checks shall run on PRs.
Content for the .git-blame-ignore-revs will be added later when the upstream commit hashes to list are fixed.
…ting Code Formatting via `clang-format`
small bugfix formatting the playtime
… settings.json (biologist79#265) The new formatting defined in .clang-format uses a tab width of 4. Fix this in .editorconfig and remove the setting in settings.json. We don't need it there.
…t-expander Bugfix for showing wrong loglevel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.