Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Fix demo #303

Merged
merged 3 commits into from
Oct 7, 2019
Merged

Fix demo #303

merged 3 commits into from
Oct 7, 2019

Conversation

maclockard
Copy link
Contributor

Fixes #269

Problem seemed to be an out of date react-spring was bringing in an incompatible version of babel run time. Fixed by bumping react-spring version and updating usage.

@FezVrasta
Copy link
Member

FezVrasta commented Sep 7, 2019

Thanks! May you take a look at the tests?

@maclockard
Copy link
Contributor Author

maclockard commented Sep 16, 2019

@FezVrasta just updated the snapshots, the react dev dep bump changed whether or not it renders context as a part of the snapshot.

Also the second example crashes when you click it, but I believe it is related to #307 since we started using a much newer react spring version fixed it! turned out to be an api change in react spring

@maclockard
Copy link
Contributor Author

@FezVrasta mind taking a look at this again?

@FezVrasta FezVrasta merged commit ada724a into floating-ui:master Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo does not build
2 participants