Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

fix: update TypeScript types to allow SVG references #299

Merged
merged 1 commit into from
Aug 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion typings/react-popper.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ interface ManagerProps {
}
export class Manager extends React.Component<ManagerProps, {}> { }

type RefHandler = (ref: HTMLElement | null) => void;
type RefHandler = (ref: HTMLElement | SVGElement | null) => void;

interface ReferenceChildrenProps {
ref: RefHandler;
Expand Down
44 changes: 44 additions & 0 deletions typings/tests/svg-test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
// Please remember to update also the Flow test files that can
// be found under `/src/__typings__` please. Thanks! 🤗

import * as React from 'react';
import { Manager, Reference, Popper } from '../..';

export const Test = () => (
<Manager>
<svg>
<Reference>{({ ref }) => <g ref={ref} />}</Reference>
</svg>
<Popper
eventsEnabled
positionFixed
modifiers={{ flip: { enabled: false } }}
>
{({
ref,
style,
placement,
outOfBoundaries,
scheduleUpdate,
arrowProps,
}) => (
<div
ref={ref}
style={{ ...style, opacity: outOfBoundaries ? 0 : 1 }}
data-placement={placement}
onClick={() => scheduleUpdate()}
>
Popper
<div ref={arrowProps.ref} style={arrowProps.style} />
</div>
)}
</Popper>
<Popper>
{({ ref, style, placement }) => (
<div ref={ref} style={style} data-placement={placement}>
Popper
</div>
)}
</Popper>
</Manager>
);