Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix corrupted rule issue #516

Merged
merged 2 commits into from
Aug 7, 2021

Conversation

itaischwartz
Copy link
Contributor

fixes #515
Fix corrupted rule issue by clearing selectedVariant when closing
add rule dialog.

Fix corrupted rule issue by clearing selectedVariant when closing
add rule dialog.
@itaischwartz
Copy link
Contributor Author

we should consider moving AddRuleDialog to a separated Vue component to avoid these kinds of issues in the future, and make the code more readable.

@itaischwartz itaischwartz changed the title Fix corrupted rule issue bugfix: Fix corrupted rule issue Aug 7, 2021
@markphelps
Copy link
Collaborator

Confirmed. Thanks for the fix @itaischwartz !!!

@markphelps markphelps merged commit 3c46c4e into flipt-io:master Aug 7, 2021
@markphelps
Copy link
Collaborator

we should consider moving AddRuleDialog to a separated Vue component to avoid these kinds of issues in the future, and make the code more readable.

I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrupted rules
2 participants