fix(ui): use available namespace as selected before default fallback #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There could be situations when previously selected or default namespace is not available for user. It could be the case that default namespace was deleted or authz has a specific rules. This PR will try to get the first available namespace before falling back to default mock. Signed-off-by: Roman Dmytrenko <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3719 +/- ##
=======================================
Coverage 64.55% 64.55%
=======================================
Files 170 170
Lines 17163 17163
=======================================
Hits 11079 11079
Misses 5393 5393
Partials 691 691
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
markphelps
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There could be situations when previously selected or default
namespace is not available for user. It could be the case that
default namespace was deleted or authz has a specific rules.
This PR will try to get the first available namespace before
falling back to default mock.
related #3688