refactor(ui): rework dropdown component #3634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flipt uses headlessui for dropdown, but it had an issue that it's impossible to specify the direction for the items. It's visible in Console for copy curl/flipt commands. Recently headlessui released v2 which has different api and requires a full refactor of components. I decided to switch to radix-ui and gradually rewrite all components with headlessui. Dropdown is the first one. The new Button component is introduced but it is not migrated. Signed-off-by: Roman Dmytrenko <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3634 +/- ##
==========================================
+ Coverage 64.27% 64.31% +0.03%
==========================================
Files 170 170
Lines 17020 17020
==========================================
+ Hits 10940 10946 +6
+ Misses 5399 5395 -4
+ Partials 681 679 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flipt uses headlessui for dropdown, but it had an issue that it's
impossible to specify the direction for the items. It's visible
in Console for copy curl/flipt commands. Recently headlessui released v2 which has different api and requires a full refactor of components. I decided to switch to radix-ui and gradually rewrite all components with headlessui. Dropdown is the first one. The new Button component is introduced but it is not migrated.