Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): use Prometheus as source for analytics to display chart #3619

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

erka
Copy link
Collaborator

@erka erka commented Nov 17, 2024

closes #2500

image

image

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 75.47170% with 26 lines in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (f5caa87) to head (7aebad1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/grpc.go 0.00% 20 Missing ⚠️
internal/server/analytics/clickhouse/client.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3619      +/-   ##
==========================================
+ Coverage   64.14%   64.31%   +0.17%     
==========================================
  Files         169      170       +1     
  Lines       16956    17020      +64     
==========================================
+ Hits        10876    10946      +70     
+ Misses       5400     5395       -5     
+ Partials      680      679       -1     
Flag Coverage Δ
unittests 64.31% <75.47%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@erka erka force-pushed the prometheus-analytics branch 2 times, most recently from e044bbb to 222fb9c Compare November 18, 2024 09:43
erka added 3 commits November 18, 2024 11:44
Signed-off-by: Roman Dmytrenko <[email protected]>
Signed-off-by: Roman Dmytrenko <[email protected]>
@erka erka marked this pull request as ready for review November 18, 2024 11:14
@erka erka requested a review from a team as a code owner November 18, 2024 11:14
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work @erka !! would you mind adding a screenshot to the PR description of how the analytics looks when connected to prometheus with some flag evaluations?

@erka erka requested a review from markphelps November 18, 2024 18:21
@erka
Copy link
Collaborator Author

erka commented Nov 18, 2024

@markphelps I have added the screenshots

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work as always @erka !!

@erka erka merged commit 49c7c3a into main Nov 18, 2024
40 checks passed
@erka erka deleted the prometheus-analytics branch November 18, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs docs Requires documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FLI-712] Epic: Flag Metrics in UI (Prometheus)
2 participants