refactor(ui): remove nightwind as dependency #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main goal of this work is to reduce the size the output css file. Also Nightwind isn't active for few years and dropping such dependency would be nice. Tailwind was changed and doesn't require a lot of work to have custom colors. Signed-off-by: Roman Dmytrenko <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3599 +/- ##
==========================================
+ Coverage 64.10% 64.14% +0.03%
==========================================
Files 169 169
Lines 16956 16956
==========================================
+ Hits 10870 10876 +6
+ Misses 5404 5400 -4
+ Partials 682 680 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Roman Dmytrenko <[email protected]>
markphelps
approved these changes
Nov 7, 2024
Signed-off-by: Roman Dmytrenko <[email protected]>
it added even more changes... |
markphelps
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this work is to reduce the size the output css file. Also Nightwind isn't active for few years and dropping such dependency would be nice. Tailwind was changed and doesn't require a lot of work to have custom colors.