refactor: clean up UI #3288
Merged
refactor: clean up UI #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## default-variant-redo #3288 +/- ##
=====================================================
Coverage 64.09% 64.10%
=====================================================
Files 168 168
Lines 13462 13462
=====================================================
+ Hits 8629 8630 +1
+ Misses 4164 4163 -1
Partials 669 669
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
erka
force-pushed
the
default-variant-redo-ui
branch
2 times, most recently
from
f61475e to
90da495
Compare
Signed-off-by: Roman Dmytrenko <[email protected]>
erka
force-pushed
the
default-variant-redo-ui
branch
from
90da495 to
14627ca
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
* feat: default variant redo Signed-off-by: Mark Phelps <[email protected]> * feat: add default variant in ui Signed-off-by: Mark Phelps <[email protected]> * chore: import/export Signed-off-by: Mark Phelps <[email protected]> * chore: ui lint issues Signed-off-by: Mark Phelps <[email protected]> * chore: add migrations for other dbs Signed-off-by: Mark Phelps <[email protected]> * chore: fix schemas; fix cli export test Signed-off-by: Mark Phelps <[email protected]> * chore: import export IT Signed-off-by: Mark Phelps <[email protected]> * chore: set IT log levels to warn to minimize log output Signed-off-by: Mark Phelps <[email protected]> * chore: rm dag import Signed-off-by: Mark Phelps <[email protected]> * chore: fix import/export IT Signed-off-by: Mark Phelps <[email protected]> * chore: fix ui test Signed-off-by: Mark Phelps <[email protected]> * chore: update testdata Signed-off-by: Mark Phelps <[email protected]> * chore: support evaluation data api Signed-off-by: Mark Phelps <[email protected]> * chore: make default variant optional Signed-off-by: Mark Phelps <[email protected]> * chore: rename default variant field in ui Signed-off-by: Mark Phelps <[email protected]> * refactor: clean up UI (#3288) Signed-off-by: Roman Dmytrenko <[email protected]> * chore: move variant form helper Signed-off-by: Mark Phelps <[email protected]> * chore: rename context key Signed-off-by: Mark Phelps <[email protected]> * chore: add legacy evaluator tests Signed-off-by: Mark Phelps <[email protected]> * chore: rm unused IVariant import Signed-off-by: Mark Phelps <[email protected]> * chore: db tests Signed-off-by: Mark Phelps <[email protected]> * chore: add IT Signed-off-by: Mark Phelps <[email protected]> * chore: check for default variant in same namespace Signed-off-by: Mark Phelps <[email protected]> * chore: add snapshot support Signed-off-by: Mark Phelps <[email protected]> * chore: try to fix ui ITs * chore: with workdir Signed-off-by: Mark Phelps <[email protected]> * chore: go mod tidy * chore: bump playwright/test Signed-off-by: Mark Phelps <[email protected]> --------- Signed-off-by: Mark Phelps <[email protected]> Signed-off-by: Roman Dmytrenko <[email protected]> Co-authored-by: Roman Dmytrenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.