-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List token based pagination #1041
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: Update Changelog Bump sass from 1.54.9 to 1.55.0 in /ui (#1040) Bump @playwright/test from 1.25.2 to 1.26.0 in /ui (#1039) Bump eslint from 8.23.0 to 8.23.1 in /ui (#1037) Bump eslint-plugin-vue from 9.4.0 to 9.5.1 in /ui (#1034) Bump @babel/preset-env from 7.19.0 to 7.19.1 in /ui (#1033) Bump @babel/core from 7.19.0 to 7.19.1 in /ui (#1032) Fix clone icons (#1038) Bump buefy from 0.9.21 to 0.9.22 in /ui (#1022) Mv config internal (#1036) Filtered GitHub webhooks (#1018)
* main: Bump golangci-lint to 1.49 (#1042)
Codecov Report
@@ Coverage Diff @@
## main #1041 +/- ##
==========================================
- Coverage 81.40% 80.83% -0.57%
==========================================
Files 17 17
Lines 1828 1915 +87
==========================================
+ Hits 1488 1548 +60
- Misses 265 283 +18
- Partials 75 84 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
GeorgeMac
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Just a handful of take it or leave it json suggestions.
…nto list-pagination * 'list-pagination' of https://github.com/flipt-io/flipt: fix: initialize shutdown context timeout after interrupt (#1057)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to use token-based pagination instead of limit/offset pagination. Fixes: #936
Changes
page_token
field to all list request typesoffset
fieldtotal_count
andnext_page_token
fields to all list response types to aide in pagination with page tokenpage_token
overoffset
when making list* requestszap.Logger
to theStore
type for future logging in the storage layer if necessaryTODO (Pre-Deploy)