Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for default variant eval #309

Merged
merged 5 commits into from
Jul 29, 2024
Merged

feat: add support for default variant eval #309

merged 5 commits into from
Jul 29, 2024

Conversation

markphelps
Copy link
Contributor

Re: flipt-io/flipt#3271

Adds default variant support to client side evaluation sdks

@markphelps markphelps requested a review from a team as a code owner July 22, 2024 18:07
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 92.48366% with 23 lines in your changes missing coverage. Please review.

Project coverage is 88.03%. Comparing base (c664970) to head (72b983e).

Files Patch % Lines
flipt-evaluation/src/lib.rs 93.64% 19 Missing ⚠️
flipt-evaluation/src/store/mod.rs 40.00% 3 Missing ⚠️
flipt-evaluation/src/models/source.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
+ Coverage   87.52%   88.03%   +0.50%     
==========================================
  Files          11       10       -1     
  Lines        3407     3711     +304     
==========================================
+ Hits         2982     3267     +285     
- Misses        425      444      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…lient-sdks into default-variant

* 'default-variant' of https://github.com/flipt-io/flipt-client-sdks:
  build(deps-dev): bump @types/node in /flipt-client-node (#308)
  build(deps-dev): bump ts-jest in /flipt-client-node (#307)
  build(deps): update mockall requirement in /flipt-engine-ffi (#306)
  build(deps): update mockall requirement in /flipt-evaluation (#305)
Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@markphelps markphelps added pending release Pending release of Flipt automerge labels Jul 22, 2024
@kodiakhq kodiakhq bot merged commit ad88594 into main Jul 29, 2024
11 checks passed
@kodiakhq kodiakhq bot deleted the default-variant branch July 29, 2024 14:56
This was referenced Jul 29, 2024
@flipt-release-bot flipt-release-bot bot mentioned this pull request Aug 25, 2024
@flipt-release-bot flipt-release-bot bot mentioned this pull request Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge pending release Pending release of Flipt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants