-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FL-3883] Remove internal storage folder if corresponding flag set #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiled f7 firmware for commit |
hedger
reviewed
Aug 7, 2024
status = f_unlink(furi_string_get_cstr(current_path)); | ||
if(status != FR_OK) break; | ||
|
||
if(!furi_string_equal(current_path, path)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can break on positive condition and move if
body out of block, but w/e
hedger
approved these changes
Aug 7, 2024
skotopes
approved these changes
Aug 9, 2024
ofabel
pushed a commit
to ofabel/flipperzero-firmware
that referenced
this pull request
Sep 26, 2024
…lipperdevices#3824) * Remove the .int directory when the flag is set * Improve error handling and variable naming * Cleanup the code * Fix updater build Co-authored-by: あく <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
FuriHalRtcFlagStorageFormatInternal
flag, emulate formatting of the internal storage by recursively deleting the/ext/.int
directory. This is done once on boot and the flag is reset afterwards.Verification
/ext/.int
directory if it contains valuable data/ext/.int
directorySettings -> Storage -> Factory Reset
a. Alternatively, connect with a companion app and perform a factory reset from there
/ext/.int
directory. The additional files and folders should be missing, with the usual dotfiles having been recreated by Flipper../fbt flash_usb_full FORCE=1
. All files in the/ext/.int
directory should be preserved.Checklist (For Reviewer)