-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ActiveRecord adapter: Fix migration error for MySQL #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/main: Update changelog Let's get more generic Switch to higher up error to catch more issues Add fix for AR adapter when table doesn't exist Add spec to demonstrate failure of AR adapter when table missing
@jnunemaker I tested against Flipper Cloud that the class ChangeFlipperGatesIndex < ActiveRecord::Migration[7.1]
disable_ddl_transaction!
def change
remove_index :flipper_gates, [:feature_key, :key, :value], unique: true
add_index :flipper_gates, [:feature_key, :key, :value], unique: true, length: {value: 255}, algorithm: :concurrently
end
end And there is no changes to the schema
|
* update-generator: Update changelog and warning message Add tests for update migrations Add `generate flipper:update` to add migrations Fix running of generator test, update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rails generate flipper:update
to generate migrations for updates #787 and update migrationFixes #789