Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while working on #760 that every adapter defines
#name
and it's just a variable set in initialize. This PR added a defaultAdapter#name
method, which is just thesnake_case
version of theClassName
.In #760 (comment), @jnunemaker said:
Currently, the ActiveRecord and Sequel adapters are the only ones that allow setting the name. Those will still work with this change. Should we allow others?