Api Flipper from Env #223
Merged
Api Flipper from Env #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm so offensive...
|
ah sweet! I definitely think this makes sense and stoked to see what you have coming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that the API can use flipper from the request env instead of having to pass an instance in. One benefit is that the middleware is more simple. It now just reads
env["flipper"]. Another benefit is that the flipper instance can be dynamically determined in upstream middleware. This allows the API to be mounted with a prefix or something and a little bit of middleware that sets the flipper instance based on that prefix.This is all backwards compatible, it just adds a bit more flexiblity for something I have up my sleeve unrelated to this. 😁 @AlexWheeler any thoughts on this either way?