Allow truthy and falsey values to be enough in group match blocks #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let(:admin_group) { flipper.group(:admins) } | ||
| let(:dev_group) { flipper.group(:devs) } | ||
| let(:truthy_group) { flipper.group(:truthy) } | ||
| let(:falsey_group) { flipper.group(:falsey) } |
There was a problem hiding this comment.
Maybe I don't know how your tests work, but are these two groups used anywhere?
There was a problem hiding this comment.
I think I was going to use them and then realized I could just use admin?. I'll remove them. Good catch.
THis is why I hate alignment...
jnunemaker
pushed a commit
that referenced
this pull request
Mar 21, 2016
Allow truthy and falsey values to be enough in group match blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ruby general is ok with truthy and falsey values over explicitly true and false. Flipper was different and expected exactly true to be returned by the flipper group match block.
Solution
Allow truthy to work. This means that blocks that return truthy values which previously would have returned false will now return true.
Fixes #110