Use str.replaceAll() with Slack link formatter function
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnetikonline
commented
Jul 31, 2024
| Object.defineProperty(o, k2, { enumerable: true, get: function() { | ||
| return m[k]; | ||
| } }); | ||
| } : function(o, m, k, k2) { | ||
| if (k2 === void 0) | ||
| k2 = k; | ||
| if (k2 === void 0) k2 = k; |
There was a problem hiding this comment.
Changes to build output with latest esbuild release.
magnetikonline
force-pushed
the
slack-link-replace-all
branch
from
585e978 to
77a40b8
Compare
magnetikonline
commented
Jul 31, 2024
| } | ||
|
|
||
| url = url.replace('<','<'); |
There was a problem hiding this comment.
This "double escape" was in error 🤦
But again, current uses of makeSlackLink() - would not have hit this issue, but fixing up since it's still incorrect/wrong.
jasonltang
approved these changes
Jul 31, 2024
|
Thx @jasonltang 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was incorrectly using
str.replace()to escape&<>characters - only would replace first instance - rather than all.https://api.slack.com/reference/surfaces/formatting#linking-urls
Granted, none of the URLs currently passed to function include these characters - but no harm in making better.
Also:
esbuildversion.semirule to ESLint ruleset.