Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove eventName property from lib.parseArgs() function #23

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Remove eventName property from lib.parseArgs() function #23

merged 4 commits into from
Apr 24, 2024

Conversation

magnetikonline
Copy link
Member

@magnetikonline magnetikonline commented Apr 23, 2024 •
edited
Loading

The eventName property is not used outside of the lib.parseArgs() function itself, so no need to return it.

Also:

  • Bump eslint -> ^8.57.0
  • Bump esbuild -> ^0.20.2

@magnetikonline magnetikonline force-pushed the remove-eventname-parse branch from 5d1d3dd to d993e8a Compare April 23, 2024 05:21
@magnetikonline magnetikonline merged commit c02ed53 into main Apr 24, 2024
1 check passed
@magnetikonline magnetikonline deleted the remove-eventname-parse branch April 24, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijay-flip vijay-flip vijay-flip approved these changes

@mathewbyrne mathewbyrne Awaiting requested review from mathewbyrne

@jasonltang jasonltang Awaiting requested review from jasonltang

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnetikonline @vijay-flip