.freeze() returns self #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
cadurso/system.pyfile and various test files to improve type hinting, add return values for chaining, and fix minor typos. The most important changes include adding theSelftype hint, updating method return types, and fixing variable names in test functions.Type Hinting and Method Return Types:
cadurso/system.py: AddedSelftype hint to the import statement and updated thefreezemethod to returnSelffor rebinding convenience. [1] [2] [3]Test Improvements:
tests/test_rule_definition_errors.py: Updated test functions to use underscore-prefixed variable names to avoid unused variable warnings and added comments to explain the purpose offreezemethod returning itself. [1] [2] [3] [4] [5] [6]Minor Fixes:
.pre-commit-config.yaml: Fixed a typo in the comment.tests/akira/conftest.py: Changed variable name to_locationto avoid unused variable warning.tests/brazil/conftest.py: Corrected typos in docstrings. [1] [2]