POC encoding/json.IndentWriter implementation #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some Benchmarks for the existing
Indent
function, against the existing indent test inputs. A typical run:Then it adds streaming support, and adds a new exported method,
IndentWriter
, which wraps anio.Writer
, and indents the stream, as documented. Benchmark results virtually identical (within expected bounds for running tests on a VM), with the addition of a new set of tests for the streaming functionality: