Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support serialization of URL #200 #201

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Support serialization of URL #200 #201

merged 2 commits into from
Sep 14, 2022

Conversation

narumincho
Copy link
Contributor

@narumincho narumincho requested a review from Skn0tt as a code owner September 14, 2022 09:14
Skn0tt
Skn0tt approved these changes Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good work! https://developer.mozilla.org/en-US/docs/Web/API/URL#browser_compatibility shows that this API is supported across all runtimes, so I think we're good to ship it!

Skn0tt
Skn0tt approved these changes Sep 14, 2022
View reviewed changes
Copy link
Collaborator

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good work!

I checked https://developer.mozilla.org/en-US/docs/Web/API/URL#browser_compatibility and verified this is supported across all runtimes, so I think we're good to ship it.

@Skn0tt
Copy link
Collaborator

Skn0tt commented Sep 14, 2022

oh, two approvals - my browser was acting weird

@Skn0tt
Copy link
Collaborator

Skn0tt commented Sep 14, 2022

@all-contributors please add @narumincho for code

@allcontributors allcontributors bot mentioned this pull request Sep 14, 2022
Merged
@allcontributors
Copy link
Contributor

@Skn0tt

I've put up a pull request to add @narumincho! 🎉

@Skn0tt Skn0tt enabled auto-merge (squash) September 14, 2022 19:11
@Skn0tt Skn0tt merged commit 23b7f71 into flightcontrolhq:main Sep 14, 2022
@Skn0tt
Copy link
Collaborator

Skn0tt commented Sep 14, 2022

published in https://github.com/blitz-js/superjson/releases/tag/v1.10.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skn0tt Skn0tt Skn0tt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narumincho @Skn0tt