Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow individual superjson instances (closes #87) #162

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

Skn0tt
Copy link
Collaborator

@Skn0tt Skn0tt commented Nov 29, 2021

this allows the creation of individual superjson instances, so there can be multiple different configurations.
it keeps the global instance in place for backwards compatibility, and b/c most users will be fine with one global config.

@Skn0tt Skn0tt marked this pull request as ready for review November 29, 2021 09:06
@Skn0tt
Copy link
Collaborator Author

Skn0tt commented Nov 30, 2021

@arthur-er I implemented your request with this Draft, and published to 1.9.0-0. Can you try that version out and report if it works for you?

new SuperJSON() should give you two independent instances.

@arthur-er
Copy link

It works as intended!

Sorry for the near year late response.

@Skn0tt
Copy link
Collaborator Author

Skn0tt commented Oct 21, 2022

good to hear that :D do you still need the functionality? if not, I'll hold out on merging this until somebody needs it - the less complexity, the better :D

@arthur-er
Copy link

yeah, i need it again now🤣

this allows the creation of individual superjson instances, so there can be multiple different configurations.
it keeps the global instance in place for backwards compatibility, and b/c most users will be fine with one global config.
@Skn0tt Skn0tt force-pushed the refactor-remove-global-namespace branch from e8fde50 to 60091c9 Compare October 21, 2022 10:19
@Skn0tt Skn0tt merged commit c66271e into main Oct 21, 2022
@Skn0tt Skn0tt deleted the refactor-remove-global-namespace branch October 21, 2022 10:22
@Skn0tt
Copy link
Collaborator Author

Skn0tt commented Oct 21, 2022

published! :)

@arthur-er
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants