Use io.Reader to avoid file size limits #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout reading its whole content on the server
this reverts "use command-line-exposed timeout for client write deadline" and "use command-line-exposed timeout for tunnel to allow writing large requests"
This fixes a race condition caused by the invalid use of sync.WaitGroup which caused "panic: sync: WaitGroup is reused before previous Wait has returned".
encountered when the chan in the server HTTP payloadHandler sends the signal before the tunnel reader started waiting fixed by obtaining the lock before sending the signal which is only available if the tunnel reader is in wait or has closed already
|
Adding some more commits that fix an issue intruduced by the bad use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the (download) file size is limited at 100MB.
If only this constant is increased, the server has to buffer all content in memory before passing it on.
In this PR we use an io.Reader to process everything as a stream.
Also we remove the file size limits and expose some timeouts to the command line timeout values of server and client.