Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redshift Fix for segment_web_page_views #17

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

lindseywatts
Copy link

@lindseywatts lindseywatts commented Jan 24, 2024

Description & motivation

When running in Redshift, due to the hard-coded source_name column, "ERROR: failed to find conversion function from unknown to text" is thrown. When changing this column to be cast as text, the issue is resolved.

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@0adamjones
Copy link

@lindseywatts Looks like you put selec instead of select in your edit, can you make 1 more commit to correct that?

@lindseywatts
Copy link
Author

Hi @0adamjones, sorry about that. Corrected!

Copy link

@0adamjones 0adamjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@0adamjones 0adamjones changed the title cast as text Redshift Fix for segment_web_page_views Jan 25, 2024
@0adamjones 0adamjones merged commit 211b728 into fleetio:main Jan 25, 2024
@lindseywatts
Copy link
Author

Fun! Thanks @0adamjones. Any idea when your next release will be that will pull this in? Thanks again!

@lindseywatts lindseywatts deleted the redshift-cast branch January 26, 2024 13:52
@0adamjones
Copy link

@lindseywatts Should be live now!

@AgustinBanchio
Copy link

Hi, I'm getting this error on BigQuery:
image

Could it be related to this latest addition?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants