Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 1.5.3 #96

Merged
merged 19 commits into from
Sep 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1ce6a80
Update tomcat version 9.0.78
MaxWaldorf Aug 2, 2023
ae24648
Update tomcat 9 source
MaxWaldorf Aug 26, 2023
991ebe4
Update guacamole to 1.5.3 and tomcat logs directory fix for synology
MaxWaldorf Sep 1, 2023
6300495
Bump actions/checkout from 3 to 4
dependabot[bot] Sep 11, 2023
cf982b5
Merge pull request #90 from flcontainers/dependabot/github_actions/de…
MaxWaldorf Sep 11, 2023
4bf20f9
Update README.md for 1.5.3
MaxWaldorf Sep 18, 2023
0bffd07
Permit custom extensions (prevent delete)
MaxWaldorf Sep 18, 2023
47365bd
Updating dev workflow to use cache
MaxWaldorf Sep 18, 2023
51abefd
cache v3
MaxWaldorf Sep 18, 2023
5c5968a
Bump docker/login-action from 2 to 3
dependabot[bot] Sep 18, 2023
bfc2252
Bump docker/metadata-action from 4 to 5
dependabot[bot] Sep 18, 2023
0612535
Bump docker/build-push-action from 4 to 5
dependabot[bot] Sep 18, 2023
6baa441
Bump docker/setup-qemu-action from 2 to 3
dependabot[bot] Sep 18, 2023
aaf7a81
Bump docker/setup-buildx-action from 2 to 3
dependabot[bot] Sep 18, 2023
dc33e66
Merge pull request #91 from flcontainers/dependabot/github_actions/de…
MaxWaldorf Sep 18, 2023
b41112c
Merge pull request #92 from flcontainers/dependabot/github_actions/de…
MaxWaldorf Sep 18, 2023
cb80663
Merge pull request #93 from flcontainers/dependabot/github_actions/de…
MaxWaldorf Sep 18, 2023
3dcf697
Merge pull request #94 from flcontainers/dependabot/github_actions/de…
MaxWaldorf Sep 18, 2023
c42239f
Merge pull request #95 from flcontainers/dependabot/github_actions/de…
MaxWaldorf Sep 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions .github/workflows/docker-image-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,27 +20,39 @@ jobs:
steps:
# Get the repository's code
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: dev

# https://github.com/docker/setup-qemu-action
- name: Set up QEMU
uses: docker/setup-qemu-action@v2
uses: docker/setup-qemu-action@v3

# https://github.com/docker/setup-buildx-action
- name: Set up Docker Buildx
id: buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3

- name: Cache Docker layers
uses: actions/cache@v3
with:
path: /tmp/.buildx-cache
# Key is named differently to avoid collision
key: ${{ runner.os }}-multi-buildx-${{ github.sha }}
restore-keys: |
${{ runner.os }}-multi-buildx

# Push to Docker Hub
- name: Login to Docker Hub
if: github.event_name != 'pull_request'
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

- name: Docker meta
id: guac
uses: docker/metadata-action@v4
uses: docker/metadata-action@v5
with:
# list of Docker images to use as base name for tags
images: |
Expand All @@ -53,10 +65,20 @@ jobs:
latest=false

- name: Build and push
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: .
platforms: linux/amd64,linux/arm64/v8,linux/ppc64le
push: ${{ github.event_name != 'pull_request' }}
tags: ${{ steps.guac.outputs.tags }}
labels: ${{ steps.guac.outputs.labels }}
cache-from: type=local,src=/tmp/.buildx-cache
# Note the mode=max here
# More: https://github.com/moby/buildkit#--export-cache-options
# And: https://github.com/docker/buildx#--cache-tonametypetypekeyvalue
cache-to: type=local,mode=max,dest=/tmp/.buildx-cache-new

- name: Move cache
run: |
rm -rf /tmp/.buildx-cache
mv /tmp/.buildx-cache-new /tmp/.buildx-cache
12 changes: 6 additions & 6 deletions .github/workflows/docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,25 +17,25 @@ jobs:
steps:
# Get the repository's code
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
# https://github.com/docker/setup-qemu-action
- name: Set up QEMU
uses: docker/setup-qemu-action@v2
uses: docker/setup-qemu-action@v3
# https://github.com/docker/setup-buildx-action
- name: Set up Docker Buildx
id: buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
# Push to Docker Hub
- name: Login to Docker Hub
if: github.event_name != 'pull_request'
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

- name: Docker meta
id: guac
uses: docker/metadata-action@v4
uses: docker/metadata-action@v5
with:
# list of Docker images to use as base name for tags
images: |
Expand All @@ -48,7 +48,7 @@ jobs:
type=semver,pattern={{major}}

- name: Build and push
uses: docker/build-push-action@v4
uses: docker/build-push-action@v5
with:
context: .
platforms: linux/amd64,linux/arm64/v8,linux/ppc64le
Expand Down
11 changes: 6 additions & 5 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ARG ALPINE_BASE_IMAGE=latest
FROM alpine:${ALPINE_BASE_IMAGE} AS builder

ARG VERSION="1.5.2"
ARG VERSION="1.5.3"
ARG TARGETPLATFORM

ENV \
Expand Down Expand Up @@ -161,7 +161,7 @@ ARG BUILD_RFC3339="2023-04-04T13:00:00Z"
ARG REVISION="local"
ARG DESCRIPTION="Fully Packaged and Multi-Arch Guacamole container"
ARG PACKAGE="flcontainers/guacamole"
ARG VERSION="1.5.2"
ARG VERSION="1.5.3"
ARG POSTGRES_HOST_AUTH_METHOD="trust"

LABEL org.opencontainers.image.ref.name="${PACKAGE}" \
Expand Down Expand Up @@ -222,8 +222,8 @@ RUN apk add --no-cache -X https://dl-cdn.alpinelinux.org/alpine/edge/testing gos

# Install tomcat
RUN mkdir /opt/tomcat
ADD https://dlcdn.apache.org/tomcat/tomcat-9/v9.0.76/bin/apache-tomcat-9.0.76.tar.gz /tmp/
RUN tar xvzf /tmp/apache-tomcat-9.0.76.tar.gz --strip-components 1 --directory /opt/tomcat
ADD https://dlcdn.apache.org/tomcat/tomcat-9/v9.0.80/bin/apache-tomcat-9.0.80.tar.gz /tmp/
RUN tar xvzf /tmp/apache-tomcat-9.0.80.tar.gz --strip-components 1 --directory /opt/tomcat
RUN chmod +x /opt/tomcat/bin/*.sh

RUN groupadd tomcat && \
Expand All @@ -232,7 +232,8 @@ useradd -s /bin/false -g tomcat -d /opt/tomcat tomcat
RUN chgrp -R tomcat /opt/tomcat && \
chmod -R g+r /opt/tomcat/conf && \
chmod g+x /opt/tomcat/conf && \
chown -R tomcat /opt/tomcat/webapps/ /opt/tomcat/work/ /opt/tomcat/temp/ /opt/tomcat/logs/
chown -R tomcat /opt/tomcat/webapps/ /opt/tomcat/work/ /opt/tomcat/temp/ /opt/tomcat/logs/ && \
chmod 777 -R /opt/tomcat/logs/

# Install guacamole-client and postgres auth adapter
RUN set -x \
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ docker run \
- vault-ksm
- history-recording-storage

More information: [Guacamole v1.5.0 release notes](https://guacamole.apache.org/releases/1.5.0/)
More information: [Guacamole v1.5.3 release notes](https://guacamole.apache.org/releases/1.5.3/)

You should only enable the extensions you require, if an extensions is not configured correctly in the `guacamole.properties` file it may prevent the system from loading. See the [official documentation](https://guacamole.apache.org/doc/gug/) for more details.

Expand Down
17 changes: 15 additions & 2 deletions filefs/usr/local/bin/_startup.sh
Original file line number Diff line number Diff line change
@@ -1,11 +1,24 @@
#!/bin/sh
echo "Preparing Config Folder"
if [ -d "/config/guacamole/" ]; then
rm -r /config/guacamole/extensions
rm /config/guacamole/extensions/guacamole-auth-duo-*.jar
rm /config/guacamole/extensions/guacamole-auth-header-*.jar
rm /config/guacamole/extensions/guacamole-auth-jdbc-mysql-*.jar
rm /config/guacamole/extensions/guacamole-auth-jdbc-postgresql-*.jar
rm /config/guacamole/extensions/guacamole-auth-jdbc-sqlserver-*.jar
rm /config/guacamole/extensions/guacamole-auth-json-*.jar
rm /config/guacamole/extensions/guacamole-auth-ldap-*.jar
rm /config/guacamole/extensions/guacamole-auth-quickconnect-*.jar
rm /config/guacamole/extensions/guacamole-auth-sso-openid-*.jar
rm /config/guacamole/extensions/guacamole-auth-sso-saml-*.jar
rm /config/guacamole/extensions/guacamole-auth-sso-cas-*.jar
rm /config/guacamole/extensions/guacamole-auth-totp-*.jar
rm /config/guacamole/extensions/guacamole-vault-ksm-*.jar
rm /config/guacamole/extensions/guacamole-history-recording-storage-*.jar
rm -r /config/guacamole/extensions-available
rm -r /config/guacamole/lib
rm -r /config/guacamole/schema
cp -r /app/guacamole/extensions /config/guacamole
cp -r /app/guacamole/extensions/*.jar /config/guacamole/extensions
cp -r /app/guacamole/extensions-available /config/guacamole
cp -r /app/guacamole/lib /config/guacamole
cp -r /app/guacamole/schema /config/guacamole
Expand Down