Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor editing changes for JOSS paper #171

Merged
merged 4 commits into from
May 17, 2024

Conversation

mstimberg
Copy link

Some minor changes to the bibliography and the formatting of the paper to finalize openjournals/joss-reviews#6590.

This also changes the word "synchronous" to "asynchronous" in the sentence "This allows for asynchronous data reads without the need for a prior download of the entire file." – I hope I did not misunderstand!

@magland
Copy link
Collaborator

magland commented May 17, 2024

Thanks @mstimberg. Actually "synchronous" was correct, although confusing. I think it's better to use the word "partial" instead.

The reading of the remote hdf5 file is actually synchronous, which is not ideal but is necessary for wasm hdf5 in a web worker with emscripten. But it doesn't make sense to point that out in that sentence, so let's use "partial data reads".

EDIT: To clarify even further... the reading is asynchronous w.r.t. the main thread, so it doesn't freeze the UI. But w.r.t. the worker thread, it is synchronous. Again, best to not use that word.

@magland magland merged commit 43a2a86 into flatironinstitute:paper May 17, 2024
@mstimberg
Copy link
Author

Understood, thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants