Memory filter implementation/improvements #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed loosely on the old memory-filters branch, and on review of the CouchDB engine code
…perations, as the active memory engine instance may have been changed after resource definition.
|
This looks good at first glance. cc @indexzero |
|
Could this be committed to one of the newest branches please? We have a production environment using couchdb - and it's all fine. But for testing we're using memory store and it fails every time when using filters. Thank you!!! |
|
@jcrugzz @indexzero could this be looked at? Using filters is causing our tests to break, since they use memory. I can confirm this pr allows to tests to work like they did before we implemented some filters. |
|
@Fishrock123 yea this does look good after closer inspection. Merging |
jcrugzz
added a commit
that referenced
this pull request
Jan 12, 2015
Memory filter implementation/improvements
|
Published as |
|
Thanks! 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement filters compatible with CouchDB for the Memory engine.
Based loosely on the old memory-filters branch, plus reading through the CouchDB view.js file to ensure compatibility.
Includes test cases.