Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight clean up around enabling distance API #7

Merged
merged 3 commits into from
May 25, 2020

Conversation

nihalsid
Copy link

Commenting / uncommenting instructions around Distance matrix api code were unclear and buggy. Replaced with a flag.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020

Codecov Report

Merging #7 into master will decrease coverage by 0.18%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   59.24%   59.05%   -0.19%     
==========================================
  Files           7        7              
  Lines         422      425       +3     
  Branches       49       50       +1     
==========================================
+ Hits          250      251       +1     
- Misses        158      159       +1     
- Partials       14       15       +1     
Impacted Files Coverage Δ
flathunter/hunter.py 38.23% <33.33%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2292ef3...4155536. Read the comment docs.

@codders
Copy link

codders commented May 25, 2020

Looks great - thanks for adding this!

Copy link

@codders codders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codders codders merged commit 5438b81 into flathunters:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants